Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCookie::appropriate_for_url should check for wss schemes in addition to https #14702
Labels
Comments
|
Please make a comment here if you intend to work on this issue. Thank you! |
|
I would like to work on this. |
|
@iamrohit7 it's all yours! |
ghost
mentioned this issue
bors-servo
added a commit
that referenced
this issue
Dec 25, 2016
Check for wss schemes in Cookie::appropriate_for_url * Also adds a new helper, `ServoUrl::is_secure_scheme`. * Refactored `CookieStorage::push` and `CookieStorage::remove` to use the new helper. <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #14702 <!-- Either: --> - [X] These changes do not require tests because we can't test the changes yet. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14722) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Dec 25, 2016
Check for wss schemes in Cookie::appropriate_for_url * Also adds a new helper, `ServoUrl::is_secure_scheme`. * Refactored `CookieStorage::push` and `CookieStorage::remove` to use the new helper. <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #14702 <!-- Either: --> - [X] These changes do not require tests because we can't test the changes yet. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14722) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Really, we should have an
is_scheme_secure(&ServoUrl)abstraction, because this gets used in #14491 as well.Code:
components/net/cookie.rsNo way to write an automated test for this, unfortunately, since we can't run SSL tests yet.