Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update http_network_or_cache_fetch to current Fetch standard #14742

Closed
mattnenterprise opened this issue Dec 27, 2016 · 5 comments
Closed

Update http_network_or_cache_fetch to current Fetch standard #14742

mattnenterprise opened this issue Dec 27, 2016 · 5 comments
Labels
A-network C-assigned

Comments

@mattnenterprise
Copy link
Contributor

@mattnenterprise mattnenterprise commented Dec 27, 2016

http_network_or_cache_fetch looks to be out of date with what is currently in the standard. It should be updated to reflect what the current standard contains.
@mattnenterprise
Copy link
Contributor Author

@mattnenterprise mattnenterprise commented Dec 27, 2016 •
edited

@jdm I'm gonna start working on this
@jdm
Copy link
Member

@jdm jdm commented Dec 27, 2016

Great! Anything in particular you're focusing on?
@mattnenterprise
Copy link
Contributor Author

@mattnenterprise mattnenterprise commented Dec 27, 2016

Currently I only see 20 steps in the code, but the spec contains 25. I would like to add the additional steps, or at least add a TODO where they should be added in the code.
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Dec 28, 2016 •
edited

Some notes (all step numbers are based on current version of the spec):

  • Step 2 on the spec is new;
  • Step 7 is new;
  • Step 9 needs update;
  • Step 13 needs update;
  • Step 22 is new;
  • Step 23 is new;
  • Step 24 is new
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Dec 28, 2016

Relevant: https://github.com/Ms2ger/servo/tree/http_network_or_cache_fetch
@mattnenterprise mattnenterprise mentioned this issue Dec 30, 2016
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Dec 30, 2016
@bors-servo
Auto merge of #14784 - mattnenterprise:fetch-api-updates, r=<try>
Loading status checks…
5944e85 
Updating http_network_or_cache_fetch to better match the fetch API spec

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #14742

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14784)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 1, 2017
@bors-servo
Auto merge of #14784 - mattnenterprise:fetch-api-updates, r=KiChjang,jdm
Loading status checks…
b337e92 
Updating http_network_or_cache_fetch to better match the fetch API spec

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14742

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14784)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 2, 2017
@bors-servo
Auto merge of #14784 - mattnenterprise:fetch-api-updates, r=jdm,KiChjang
Loading status checks…
987b640 
Updating http_network_or_cache_fetch to better match the fetch API spec

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14742

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14784)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-network C-assigned
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Updating http_network_or_cache_fetch to better match the fetch API spec
4 participants
@jdm @Ms2ger @KiChjang @mattnenterprise
You can’t perform that action at this time.