Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradients render in the wrong direction #14745

Closed
cbrewster opened this issue Dec 27, 2016 · 1 comment
Closed

Gradients render in the wrong direction #14745

cbrewster opened this issue Dec 27, 2016 · 1 comment
Labels
A-gfx/rendering C-assigned

Comments

@cbrewster
Copy link
Member

@cbrewster cbrewster commented Dec 27, 2016

Notice the Sign Up and Sign up for GitHub buttoms.

Servo:
screen shot 2016-12-27 at 4 04 41 pm
Firefox:
screen shot 2016-12-27 at 4 05 53 pm
@DominoTree
Copy link
Contributor

@DominoTree DominoTree commented Dec 27, 2016

I was doing some work in this area a couple of weeks ago - I'll see if I can hunt this down.
This was referenced Dec 27, 2016
Merged
Closed
bors-servo added a commit that referenced this issue Dec 28, 2016
@bors-servo
Auto merge of #14746 - DominoTree:fix-linear-gradient, r=emilio
Loading status checks…
3911fbe 
Default is top-to-bottom if unset, not bottom-to-top

<!-- Please describe your changes on the following line: -->
Reverse linear gradient direction if not explicitly specified to match expected default behavior

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14745 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14746)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 28, 2016
@bors-servo
Auto merge of #14746 - DominoTree:fix-linear-gradient, r=emilio
Loading status checks…
adb3e12 
Default is top-to-bottom if unset, not bottom-to-top

<!-- Please describe your changes on the following line: -->
Reverse linear gradient direction if not explicitly specified to match expected default behavior

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14745 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14746)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-gfx/rendering C-assigned
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Default is top-to-bottom if unset, not bottom-to-top
2 participants
@DominoTree @cbrewster
You can’t perform that action at this time.