Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement ArrayBuffer and ArrayBufferView variants of WebSocket::Send #14761
Comments
|
I figured it out - all of the arraybuffer tests provide arraybuffers as input, but we haven't implemented that yet so they get converted to strings. This means that the tests all send input which is the stringified arraybuffer object, so they receive a string like |
|
This needs to wait until #5014, unfortunately. I don't think we can handle overloads of webidl methods that include object types. |
|
We probably could, but would need to handle interface types manually... Not sure if the distinction would be detectable. |
|
Duplicate of #20347. |
https://dxr.mozilla.org/servo/source/tests/wpt/web-platform-tests/websockets/binary/004.html fails with:
This corresponds to
assert_equals(e.data.byteLength, datasize);in the test, wheree.datais supposed to be an ArrayBuffer object.console.log(e.data)shows[object ArrayBuffer], whileconsole.log(e.data.byteLength)showsundefined, andconsole.log(Object.getPrototypeOf(e.data))shows the empty string. I am very confused by these results.