Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRequest mode doesn't have websocket option #14785
Closed
Labels
Comments
|
Is it as simple as adding WebSocket to the RequestMode enum? |
|
Yes. |
|
PR Link #14895 |
|
Adding the WebSocket enum variant now triggers implementation error in dom/request.rs. Tried to add match case in dom/request.rs but since variant isn't included in bindings, cannot add it in. Ideas? |
bors-servo
added a commit
that referenced
this issue
Jan 8, 2017
Added Websocket to RequestMode enum Added Websocket to RequestMode enum --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #14785 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because matching the enum should have default control flow. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14895) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
RequestModeincomponents/net_traits/request.rscould possibly have the value of "websocket" according to the spec. CurrentlyRequestModedoesn't have the option of being websocket so it should be added.