Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github sign in button on MDN is too tall #14807

Closed
jdm opened this issue Dec 31, 2016 · 5 comments
Closed

Github sign in button on MDN is too tall #14807

jdm opened this issue Dec 31, 2016 · 5 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Dec 31, 2016

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/then
Firefox:
screen shot 2016-12-31 at 11 43 00 am

Servo:
screen shot 2016-12-31 at 11 42 32 am

Very preliminary reduction:

<style>
#nav-sec {
        position: absolute;
        top: 12px;
        right: 200px;
        z-index: 36;
        font-size: 13px;
        font-size: .929rem;
border: 1px solid black;
}
.login-link i[class^="icon-"] {
        float: right;
}
.login i[class^="icon-"] {
        font-size: 15.6px;
        font-size: 1.114rem;
        line-height: 20px;
        vertical-align: top;
}
.icon-github::before {
        content: "\f09b";
}
</style>
<div id="nav-sec">

                  <ul>
                  <li><div class="login">


       <a href="/users/github/login/?next=%2Fen-US%2Fdocs%2FWeb%2FJavaScript%2FReference%2FGlobal_Objects%2FPromise%2Fthen" class="login-link js-login-link" data-service="GitHub">
        Sign in
        <i class="icon-github" aria-hidden="true"></i>
      </a>

</div></li>
                </ul>

    </div>
@DominoTree
Copy link
Contributor

@DominoTree DominoTree commented Jan 1, 2017

I'll see if I can fix this one

@jdm jdm added the C-assigned label Jan 1, 2017
@jdm
Copy link
Member Author

@jdm jdm commented Jan 1, 2017

I definitely recommend reducing it to a minimal testcase first.

@DominoTree
Copy link
Contributor

@DominoTree DominoTree commented Jan 1, 2017

Looks like it's the float, the example below still triggers it

<style>
.float {
	float: left;
}
</style>
beside this text
<div class="float">This should be</div>

Firefox:
Firefox

Servo:
Servo

@DominoTree
Copy link
Contributor

@DominoTree DominoTree commented Jan 1, 2017

Think this is #13683

@jdm jdm added the A-webcompat label Jan 4, 2017
@stshine
Copy link
Contributor

@stshine stshine commented May 5, 2017

Closed in favor of #13683.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.