Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to adjust end of iteration check for decimal animation-iteration-count #14858

Closed
hiikezoe opened this issue Jan 5, 2017 · 2 comments · Fixed by #27032
Closed

Need to adjust end of iteration check for decimal animation-iteration-count #14858

hiikezoe opened this issue Jan 5, 2017 · 2 comments · Fixed by #27032
Assignees
@mrobinson
Labels
A-layout/animations

Comments

@hiikezoe
Copy link
Contributor

hiikezoe commented Jan 5, 2017

This is a follow-up issue of #14851.

In #14851, we allow decimal value for animation-iteration-count, as a result, the iteration duration of the final iteration is not reached to the end of duration of the final iteration if the iteration-count is not integer. So, IIUC, a check 'now < state.started_at + state.duration' [1] in update_animation_state will miss the end of iteration check inside KeyframesAnimationState::tick().

[1]

servo/components/layout/animation.rs

Line 79 in 4216c16

now < state.started_at + state.duration || state.tick()

CC @emilio
@hiikezoe hiikezoe mentioned this issue Jan 5, 2017
Merged
3 tasks
@nox
Copy link
Contributor

nox commented Oct 7, 2017

@emilio Is this still relevant?

@nox nox added the C-is-this-done It is unclear if the issue has been resolved label Oct 7, 2017
@mrobinson
Copy link
Member

Yep, this is still an issue. Hopefully this is something that should be pretty straight-forward to fix once the animations and transitions code has been reworked.

@mrobinson mrobinson removed the C-is-this-done It is unclear if the issue has been resolved label May 6, 2020
@mrobinson mrobinson self-assigned this May 6, 2020
@mrobinson mrobinson mentioned this issue May 14, 2020
Closed
21 tasks
mrobinson added a commit to mrobinson/servo that referenced this issue Jun 22, 2020
@mrobinson
animations: Finish support for fractional iteration lengths
222a650 
This change also improves support for creating animations with negative
delays, as that is necessary to test support for fractional iteration
lengths.

Fixes: servo#14858
mrobinson added a commit to mrobinson/servo that referenced this issue Jun 22, 2020
@mrobinson
animations: Finish support for fractional iteration counts
ab19b5b 
This change also improves support for creating animations with negative
delays, as that is necessary to test support for fractional iteration
lengths.

Fixes: servo#14858
@mrobinson mrobinson mentioned this issue Jun 22, 2020
Merged
4 tasks
mrobinson added a commit to mrobinson/servo that referenced this issue Jun 23, 2020
@mrobinson
animations: Finish support for fractional iteration counts
1bb0796 
This change also improves support for creating animations with negative
delays, as that is necessary to test support for fractional iteration
lengths.

Fixes: servo#14858
mrobinson added a commit to mrobinson/servo that referenced this issue Jun 23, 2020
@mrobinson
animations: Finish support for fractional iteration counts
d319b3b 
This change also improves support for creating animations with negative
delays, as that is necessary to test support for fractional iteration
lengths.

Fixes: servo#14858
bors-servo added a commit that referenced this issue Jun 23, 2020
@bors-servo
Auto merge of #27032 - mrobinson:fractional-iteration, r=emilio
09c07d0 
animations: Finish support for fractional iteration counts

This change also improves support for creating animations with negative
delays, as that is necessary to test support for fractional iteration
lengths.

Fixes: #14858

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14858
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
mrobinson added a commit to mrobinson/servo that referenced this issue Jun 24, 2020
@mrobinson
animations: Finish support for fractional iteration counts
e1254d7 
This change also improves support for creating animations with negative
delays, as that is necessary to test support for fractional iteration
lengths.

This change also adjusts existing Servo animation tests which assumed
that advancing to the exact moment of the end of the animation would be
considered "before the end." With this change, this moment is "after the
end."

Fixes: servo#14858
bors-servo added a commit that referenced this issue Jun 24, 2020
@bors-servo
Auto merge of #27032 - mrobinson:fractional-iteration, r=<try>
5b3ede2 
animations: Finish support for fractional iteration counts

This change also improves support for creating animations with negative
delays, as that is necessary to test support for fractional iteration
lengths.

Fixes: #14858

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14858
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Jun 24, 2020
@bors-servo
Auto merge of #27032 - mrobinson:fractional-iteration, r=<try>
eb56ac0 
animations: Finish support for fractional iteration counts

This change also improves support for creating animations with negative
delays, as that is necessary to test support for fractional iteration
lengths.

Fixes: #14858

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14858
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Jun 24, 2020
@bors-servo
Auto merge of #27032 - mrobinson:fractional-iteration, r=<try>
c3a1b47 
animations: Finish support for fractional iteration counts

This change also improves support for creating animations with negative
delays, as that is necessary to test support for fractional iteration
lengths.

Fixes: #14858

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14858
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Jun 24, 2020
@bors-servo
Auto merge of #27032 - mrobinson:fractional-iteration, r=jdm
6659e90 
animations: Finish support for fractional iteration counts

This change also improves support for creating animations with negative
delays, as that is necessary to test support for fractional iteration
lengths.

Fixes: #14858

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14858
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrobinson mrobinson

Labels
A-layout/animations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

animations: Finish support for fractional iteration counts mrobinson/servo
4 participants
@mrobinson @nox @hiikezoe @emilio