Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serializing origins #14892

Closed
asajeffrey opened this issue Jan 6, 2017 · 3 comments
Closed

Serializing origins #14892

asajeffrey opened this issue Jan 6, 2017 · 3 comments
Assignees
@asajeffrey
Labels
A-constellation A-content/script

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jan 6, 2017

IRC conversation with @bzbarsky: http://logs.glob.uno/?c=mozilla%23servo&s=6+Jan+2017&e=6+Jan+2017#c588833

Origin objects have object identity, which can be observed in at least two ways: a) we create new opaque origins, then check their identity, and b) document.domain allows origin objects to be mutated.

This is fine for threads which share an address space, not so good for serializing origins from script to the constellation. In particular, we need to store origins in the session history, so that if an about:blank page is reloaded, it does so with the same origin as it had before.
This was referenced Jan 6, 2017
Open
Closed
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Jan 9, 2017

Did we end up moving to process-global counters rather than uuids for opaque origins? We would probably need to revert that if we want to send origins across processes.
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Jan 10, 2017

We did move away from uuids and we would have to move back if we wanted them to be global.
@asajeffrey asajeffrey self-assigned this Jan 10, 2017
@asajeffrey asajeffrey changed the title Sending origins from script to the constellation Serializing origins Feb 7, 2017
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Feb 7, 2017

This is needed in a few places: anywhere we're sending origins to the contstellation, and anywhere where a helper thread needs to know the origin that its acting on behalf of, notably fetch.
@asajeffrey asajeffrey mentioned this issue Feb 8, 2017
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Feb 22, 2017
@bors-servo
Auto merge of #15438 - asajeffrey:url-serializable-origin, r=jdm
Loading status checks…
124f0f3 
Add ImmutableOrigin to allow for serializing origins

<!-- Please describe your changes on the following line: -->

This PR adds a serializable type `ImmutableOrigin` and a non-serializable type `MutableOrigin`. The immutable type represents an origin with `null` domain, and the mutable type represents an origin with a mutable domain. This separation is needed for implementing setting `document.domain`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14892.
- [X] These changes do not require tests because it's a refactoring which will enable other features.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15438)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 22, 2017
@bors-servo
Auto merge of #15438 - asajeffrey:url-serializable-origin, r=jdm
Loading status checks…
f11ea5c 
Add ImmutableOrigin to allow for serializing origins

<!-- Please describe your changes on the following line: -->

This PR adds a serializable type `ImmutableOrigin` and a non-serializable type `MutableOrigin`. The immutable type represents an origin with `null` domain, and the mutable type represents an origin with a mutable domain. This separation is needed for implementing setting `document.domain`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14892.
- [X] These changes do not require tests because it's a refactoring which will enable other features.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15438)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 22, 2017
@bors-servo
Auto merge of #15438 - asajeffrey:url-serializable-origin, r=jdm
Loading status checks…
2f73c51 
Add ImmutableOrigin to allow for serializing origins

<!-- Please describe your changes on the following line: -->

This PR adds a serializable type `ImmutableOrigin` and a non-serializable type `MutableOrigin`. The immutable type represents an origin with `null` domain, and the mutable type represents an origin with a mutable domain. This separation is needed for implementing setting `document.domain`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14892.
- [X] These changes do not require tests because it's a refactoring which will enable other features.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15438)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 22, 2017
@bors-servo
Auto merge of #15438 - asajeffrey:url-serializable-origin, r=jdm
Loading status checks…
78e8c31 
Add ImmutableOrigin to allow for serializing origins

<!-- Please describe your changes on the following line: -->

This PR adds a serializable type `ImmutableOrigin` and a non-serializable type `MutableOrigin`. The immutable type represents an origin with `null` domain, and the mutable type represents an origin with a mutable domain. This separation is needed for implementing setting `document.domain`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14892.
- [X] These changes do not require tests because it's a refactoring which will enable other features.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15438)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asajeffrey asajeffrey

Labels
A-constellation A-content/script
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add ImmutableOrigin to allow for serializing origins
2 participants
@Ms2ger @asajeffrey
You can’t perform that action at this time.