Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a thorough suite of compile-fail tests that verify safety features of our rooting analysis #14903

Open
jdm opened this issue Jan 6, 2017 · 5 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Jan 6, 2017

We have the ability to write tests that verify that they do not compile. We should figure out what setup is necessary to write tests that verify that dangerous DOM constructs do not compile, make it as easy as possible to write these tests, and then systematically create a testsuite to protect us against accidental weakening of our static analysis.

Tentatively assigning this work to @Ms2ger as part of the "fix all known JS crashes" effort for this quarter.

@DemiMarie
Copy link

@DemiMarie DemiMarie commented Jul 3, 2017

Ping?

@jdm
Copy link
Member Author

@jdm jdm commented Jul 3, 2017

@DemiMarie Comments like "ping" are not useful. If you have a question, please ask that. Assume that no activity in an issue means that nobody has put effort into it.

@jdm jdm unassigned Ms2ger Jul 3, 2017
@DemiMarie
Copy link

@DemiMarie DemiMarie commented Jul 3, 2017

@jdm Sorry, and thanks for the explanation. I apologize.

@nox
Copy link
Member

@nox nox commented Oct 7, 2017

We wrote such tests.

@nox nox closed this Oct 7, 2017
@jdm
Copy link
Member Author

@jdm jdm commented Oct 7, 2017

I would like to leave this open; it is hardly comprehensive.

@jdm jdm reopened this Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.