Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix computation of {align,justify}-{content,items,self} (and add parsing / serialization if necessary) #15001
Comments
|
It seems some of the properties are either not implemented ( |
Stylo: Implement align-content and justify-content This implements parsing and serialization of `align-content` and `justify-content` for Stylo. The implementation should match Gecko exactly (which means it's not exactly up-to-date with the latest draft spec). This is a Stylo-only change; it leaves the current Servo code (which matches an older spec) unchanged for now. r? @Manishearth - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #15001 (github issue number if applicable). - [x] These changes do not require tests because they are stylo-only <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15533) <!-- Reviewable:end -->
stylo: Implement 'align-self' and 'justify-self' Stylo-only patch to match Gecko property support. Part of #15001. r? @Manishearth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15576) <!-- Reviewable:end -->
stylo: Implement 'align-self' and 'justify-self' Stylo-only patch to match Gecko property support. Part of #15001. r? @Manishearth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15576) <!-- Reviewable:end -->
|
With the latest pull requests, all these properties are supported in Stylo but some are still not supported or only partially-supported in Servo. In Stylo they are now representated by bitflags that are shared with Gecko. If we want to use the same representation in Servo, we'll need to change the way these bitflags are implemented to not depend on Gecko bindings. |
stylo: Implement align-items and justify-items Stylo-only patch to match Gecko property support. Part of #15001. r? @Manishearth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15606) <!-- Reviewable:end -->
|
@mbrubeck Although parsing and serialization are implemented, it still lacks gecko glue, and thus gecko still cannot get the computed result of these properties. |
upsuper
modified the milestones:
Stylo: test_value_storage.html failures,
Stylo: Style system mochitests
|
Could you describe a bit more what is there to do, in which files, with what code? |
|
I took care of what remained, I think. |
It seems there are relatively complicated rules for computed value of those 6 properties, and currently Stylo's result of them seems to be mostly wrong.
Please see Gecko's test_align_justify_computed_values.html as a reference.