Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tidy's `BLOCKED_PACKAGES` list to its config #15014

Closed
wafflespeanut opened this issue Jan 13, 2017 · 3 comments
Closed

Move tidy's `BLOCKED_PACKAGES` list to its config #15014

wafflespeanut opened this issue Jan 13, 2017 · 3 comments
Labels
E-easy L-python

Comments

@wafflespeanut
Copy link
Member

@wafflespeanut wafflespeanut commented Jan 13, 2017 •
edited

It was added in #14351, but it should be in servo-tidy.toml along with the other configurable things.

Code: python/tidy/servo_tidy/tidy.py
@highfive
Copy link

@highfive highfive commented Jan 13, 2017

Please make a comment here if you intend to work on this issue. Thank you!
@wafflespeanut wafflespeanut changed the title Move `BLOCKED_PACKAGES` list to the config Move tidy's `BLOCKED_PACKAGES` list to its config Jan 13, 2017
@mdevlamynck
Copy link
Contributor

@mdevlamynck mdevlamynck commented Jan 14, 2017

Hi, I'm interested in working on this, seems easy enough for a first contribution.
@wafflespeanut
Copy link
Member Author

@wafflespeanut wafflespeanut commented Jan 14, 2017

Oh, please go ahead! :)
@mdevlamynck mdevlamynck mentioned this issue Jan 14, 2017
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jan 14, 2017
@bors-servo
Auto merge of #15023 - mdevlamynck:tidy-config, r=Wafflespeanut
Loading status checks…
7eb811b 
Moved tidy's BLOCKED_PACKAGES to the config file

<!-- Please describe your changes on the following line: -->
Moved tidy.py's BLOCKED_PACKAGES to servo-tidy.toml.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15014 (github issue number if applicable).

<!-- Either: -->
- [X] These changes do not require tests because this is a refactor and the existing tests have been adapted.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15023)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy L-python
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Moved tidy's BLOCKED_PACKAGES to the config file
3 participants
@mdevlamynck @highfive @wafflespeanut
You can’t perform that action at this time.