Declaration must be ignored if it includes CSS-wide keyword as part, but not whole, of it #15054

upsuper · 2017-01-17T00:12:24Z

For example the following code:

<!DOCTYPE html>
<p style="font-family: test, initial"></p>
<script>
alert(document.querySelector('p').style.fontFamily);
</script>

The declaration of font-family must be dropped because the CSS-wide keyword initial is not a valid <custom-ident>.

There are also examples that CSS-wide keywords is accepted as something other than <custom-ident>:

<!DOCTYPE html>
<p style="transform-origin: 11% 11% initial"></p>
<script>
alert(document.querySelector('p').style.transformOrigin);
</script>

In the example above, the initial value should not be accepted at all given the grammar.

upsuper · 2017-01-17T00:13:34Z

This seems to be a fundamental issue in CSS parser of Servo.

@SimonSapin could you have a look at this issue?

SimonSapin · 2017-01-26T14:43:54Z

#15183 fixes the font-family case. (Note though that the definition of font-family does not refer to <custom-ident>, it excludes some keywords explicitly.)

With a quick look at the parsing code for transform-origin I don’t understand how this can happen. I’ll look some more. But I don’t think this is "fundamental", for example style.marginTop is the empty string with margin-top: 4px inital.

upsuper mentioned this issue Jan 17, 2017

Should not serialize shorthand when it is partly inherit or initial #15004

Closed

upsuper added the A-content/css label Jan 24, 2017

upsuper mentioned this issue Feb 6, 2017

Fix style system mochitest failures in stylo #15404

Closed

upsuper added this to the Stylo: Style system mochitests milestone Feb 10, 2017

bors-servo closed this in 95356c6 Apr 13, 2017

servo / servo

Declaration must be ignored if it includes CSS-wide keyword as part, but not whole, of it #15054

Declaration must be ignored if it includes CSS-wide keyword as part, but not whole, of it #15054

upsuper commented Jan 17, 2017

upsuper commented Jan 17, 2017

SimonSapin commented Jan 26, 2017

servo / servo

Join GitHub today

Declaration must be ignored if it includes CSS-wide keyword as part, but not whole, of it #15054

Declaration must be ignored if it includes CSS-wide keyword as part, but not whole, of it #15054

Comments

upsuper commented Jan 17, 2017

upsuper commented Jan 17, 2017

SimonSapin commented Jan 26, 2017