Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyword values of timing function should not be computed to bezier function #15086

Closed
upsuper opened this issue Jan 18, 2017 · 2 comments
Closed

Keyword values of timing function should not be computed to bezier function #15086

upsuper opened this issue Jan 18, 2017 · 2 comments
Labels
A-content/css
Milestone
Stylo: Style syst...

Comments

@upsuper
Copy link
Member

@upsuper upsuper commented Jan 18, 2017

Per spec, the computed value of timing function is same as specified value, and in both Gecko and Blink, the keyword values are perserved in computed value.

Test the following code:

<!DOCTYPE html>
<div id="x"></div>
<script>
alert(getComputedStyle(x).animationTimingFunction);
x.style.animationTimingFunction = 'ease';
alert(getComputedStyle(x).animationTimingFunction);
</script>

In Gecko and Blink, both alerts show ease, while in Stylo, the first shows ease while the second shows cubic-bezier(0.25, 0.1, 0.25, 1), which is incorrect.

cc @hiikezoe
@hiikezoe
Copy link
Contributor

@hiikezoe hiikezoe commented Jan 18, 2017

Yes, I've noticed this. In my understandings, to resolve this we should pass the specified value to set_animation_timing_function() instead of computed one. I guess we need to fix cascade_property() in helpers.mako.rs? Or computed_value for transition_timing_function should have specified value.
@upsuper
Copy link
Member Author

@upsuper upsuper commented Jan 18, 2017

I guess for this value we don't need to distinguish computed value from specified value at all. They should simply have the same type.
@upsuper upsuper mentioned this issue Feb 6, 2017
Closed
@hiikezoe hiikezoe mentioned this issue Apr 27, 2017
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Apr 27, 2017
@bors-servo
Auto merge of #16640 - hiikezoe:timing-function, r=<try>
Loading status checks…
f1820a8 
Use FunctionKeyword for computed_value of timing function

<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1358330

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15086

<!-- Either: -->
- [X] These changes do not require tests because mozilla-central has test cases.  There might be some test cases in servo tree.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16640)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 28, 2017
@bors-servo
Auto merge of #16640 - hiikezoe:timing-function, r=<try>
Loading status checks…
353556d 
Use FunctionKeyword for computed_value of timing function

<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1358330

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15086

<!-- Either: -->
- [X] These changes do not require tests because mozilla-central has test cases.  There might be some test cases in servo tree.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16640)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 28, 2017
@bors-servo
Auto merge of #16640 - hiikezoe:timing-function, r=<try>
Loading status checks…
276034b 
Use FunctionKeyword for computed_value of timing function

<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1358330

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15086

<!-- Either: -->
- [X] These changes do not require tests because mozilla-central has test cases.  There might be some test cases in servo tree.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16640)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 28, 2017
@bors-servo
Auto merge of #16640 - hiikezoe:timing-function, r=<try>
Loading status checks…
daca90f 
Use FunctionKeyword for computed_value of timing function

<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1358330

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15086

<!-- Either: -->
- [X] These changes do not require tests because mozilla-central has test cases.  There might be some test cases in servo tree.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16640)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 28, 2017
@bors-servo
Auto merge of #16640 - hiikezoe:timing-function, r=<try>
Loading status checks…
23aaa0f 
Use FunctionKeyword for computed_value of timing function

<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1358330

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15086

<!-- Either: -->
- [X] These changes do not require tests because mozilla-central has test cases.  There might be some test cases in servo tree.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16640)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 29, 2017
@bors-servo
Auto merge of #16640 - hiikezoe:timing-function, r=xidorn
Loading status checks…
93a513c 
Use FunctionKeyword for computed_value of timing function

<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1358330

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15086

<!-- Either: -->
- [X] These changes do not require tests because mozilla-central has test cases.  There might be some test cases in servo tree.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16640)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/css
Projects
None yet
Milestone
Stylo: Style syst...
Linked pull requests

Successfully merging a pull request may close this issue.

Use FunctionKeyword for computed_value of timing function
2 participants
@hiikezoe @upsuper
You can’t perform that action at this time.