Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page zoom is broken #15130

Open
jdm opened this issue Jan 20, 2017 · 1 comment
Open

Page zoom is broken #15130

jdm opened this issue Jan 20, 2017 · 1 comment

Comments

@jdm
Copy link
Member

@jdm jdm commented Jan 20, 2017

With the following patch applied, pressing cmd and + produces broken rendering:

diff --git a/ports/glutin/window.rs b/ports/glutin/window.rs
index e856547..70507d7 100644
--- a/ports/glutin/window.rs
+++ b/ports/glutin/window.rs
@@ -995,7 +995,7 @@ impl WindowMethods for Window {
     /// Helper function to handle keyboard events.
     fn handle_key(&self, ch: Option<char>, key: Key, mods: constellation_msg::KeyModifiers) {
         match (mods, ch, key) {
-            (_, Some('+'), _) => {
+            (_, Some('='), _) => {
                 if mods & !SHIFT == CMD_OR_CONTROL {
                     self.event_queue.borrow_mut().push(WindowEvent::Zoom(1.1));
                 } else if mods & !SHIFT == CMD_OR_CONTROL | ALT {
@jdm jdm added the A-gfx/rendering label Jan 20, 2017
@jdm
Copy link
Member Author

@jdm jdm commented Jan 20, 2017

Base rendering:
screen shot 2017-01-20 at 4 04 38 pm
After one zoom:
screen shot 2017-01-20 at 4 04 46 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.