Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider doing text-overflow only at display list building. #15144

Open
emilio opened this issue Jan 22, 2017 · 6 comments
Open

Consider doing text-overflow only at display list building. #15144

emilio opened this issue Jan 22, 2017 · 6 comments

Comments

@emilio
Copy link
Member

@emilio emilio commented Jan 22, 2017

I don't think our handling of text-overflow is extremely complex, but I think it could be simplified (we'd get rid of TruncatedFragments, etc), if we could handle it at display list building.

What do you think @notriddle?

@emilio
Copy link
Member Author

@emilio emilio commented Jan 22, 2017

Also @mbrubeck may have opinions on this?

@notriddle
Copy link
Contributor

@notriddle notriddle commented Jan 22, 2017

What do you think @notriddle?

I think it's a good idea.

@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Jan 23, 2017

👍 Getting rid of TruncatedFragment would be nice.

@emilio
Copy link
Member Author

@emilio emilio commented May 23, 2017

Turns out, while not super-complex, it's super-broken, d'oh :)

(#17009)

@stshine
Copy link
Contributor

@stshine stshine commented Jul 18, 2017

This looks more complicated than it seems, because we still need the layout the text-overflow value to get its length during layout. (I guess this is the reason that all other engines do not support string values.)

@nox
Copy link
Member

@nox nox commented Oct 7, 2017

Is this still something we think is doable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.