Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripts from javascript: URLs don't get executed in the right global #15147

Closed
nox opened this issue Jan 22, 2017 · 3 comments
Closed

Scripts from javascript: URLs don't get executed in the right global #15147

nox opened this issue Jan 22, 2017 · 3 comments
Labels
A-content/script

Comments

@nox
Copy link
Member

@nox nox commented Jan 22, 2017

They should get executed in the browsing context container's window, not the one that is created for navigation.
@nox nox removed the C-needs-test label Jan 23, 2017
@nox
Copy link
Member Author

@nox nox commented Jan 23, 2017

Most remaining script_scheduling tests fail for that reason. They try to run log(...) in a global where log is undefined.
@tetsuharuohzeki
Copy link
Member

@tetsuharuohzeki tetsuharuohzeki commented Feb 28, 2017

Is #15763 related to this?
@nox
Copy link
Member Author

@nox nox commented Feb 28, 2017

Probably yes.
@jdm jdm mentioned this issue May 4, 2017
Closed
@danielj41 danielj41 mentioned this issue May 29, 2017
Merged
4 of 4 tasks complete
@bspeice bspeice mentioned this issue Jun 6, 2017
Closed
0 of 1 task complete
bors-servo added a commit that referenced this issue Sep 9, 2017
@bors-servo
Auto merge of #17083 - danielj41:javascript-url-global-3, r=jdm
Loading status checks…
b8bec12 
"javascript:" urls: execute in correct global scope

<!-- Please describe your changes on the following line: -->

#### Summary

This pull request makes `javascript:` urls execute in the correct global scope.

#### Example

```html
<script> var x = 4; </script>

<!-- this branch: logs "4" -->
<!-- master: undefined variable error -->
<a href="javascript:console.log(x)">link</a>
```

#### Questions

I'm new to servo and rust, so I'm unsure about these changes. In particular:
  * What's the appropriate place to evaluate the js?
    * I moved it to `handle_navigate`, but I'm not sure if this will catch all occurrences of `javascript:` urls. I also don't know if this will execute in the correct thread and the correct window.
  * What should I do with the result of the js evaluation?
    * I just ignored it. The previous behavior displayed it as the content of a new page load.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15147, #16718

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17083)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Sep 9, 2017
@bors-servo
Auto merge of #17083 - danielj41:javascript-url-global-3, r=jdm
Loading status checks…
40c8a63 
"javascript:" urls: execute in correct global scope

<!-- Please describe your changes on the following line: -->

#### Summary

This pull request makes `javascript:` urls execute in the correct global scope.

#### Example

```html
<script> var x = 4; </script>

<!-- this branch: logs "4" -->
<!-- master: undefined variable error -->
<a href="javascript:console.log(x)">link</a>
```

#### Questions

I'm new to servo and rust, so I'm unsure about these changes. In particular:
  * What's the appropriate place to evaluate the js?
    * I moved it to `handle_navigate`, but I'm not sure if this will catch all occurrences of `javascript:` urls. I also don't know if this will execute in the correct thread and the correct window.
  * What should I do with the result of the js evaluation?
    * I just ignored it. The previous behavior displayed it as the content of a new page load.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15147, #16718

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17083)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/script
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

"javascript:" urls: execute in correct global scope
3 participants
@jdm @nox @tetsuharuohzeki
You can’t perform that action at this time.