Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upiframe-append-to-child-document.html panics while trying to deal with a framed content changed notification #15196
Labels
Comments
|
Re-ran the test. Good news, it no longer panics! Bad news, it FAILs instead :/ |
bors-servo
added a commit
that referenced
this issue
Jun 23, 2017
…-document, r=emilio Re-enabled iframe-append-to-child-document.html <!-- Please describe your changes on the following line: --> Re-enabled a WPT test. Don't get too excited, the test FAILs. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15196 - [X] These changes do not require tests because it's re-enabling a test. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17480) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jun 23, 2017
…-document, r=emilio Re-enabled iframe-append-to-child-document.html <!-- Please describe your changes on the following line: --> Re-enabled a WPT test. Don't get too excited, the test FAILs. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15196 - [X] These changes do not require tests because it's re-enabling a test. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17480) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's disabled claiming that #14411 is the cause of it failing. I tried reenabling it and running it, and got this output:
@asajeffrey This might be up your alley.