Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{fill,stroke}-opacity should support SVG-in-OT values context-{fill,stroke}-opacity #15211

Closed
upsuper opened this issue Jan 25, 2017 · 11 comments
Closed

Comments

@upsuper
Copy link
Member

@upsuper upsuper commented Jan 25, 2017

I don't find any formal definition of these values... but Gecko supports them... cc @heycam

@highfive
Copy link

@highfive highfive commented Apr 11, 2017

cc @emilio

@upsuper
Copy link
Member Author

@upsuper upsuper commented Apr 11, 2017

@nox
Copy link
Member

@nox nox commented Apr 20, 2017

What are the computed values for context-fill-opacity and context-stroke-opacity?

Should stroke-width, stroke-dasharray and stroke-dashoffset also support context-value like the spec you linked says?

@upsuper
Copy link
Member Author

@upsuper upsuper commented Apr 22, 2017

What are the computed values for context-fill-opacity and context-stroke-opacity?

Seems to be some flags in nsStyleSVG::mContextFlags. See nsStyleStruct.h.

Should stroke-width, stroke-dasharray and stroke-dashoffset also support context-value like the spec you linked says?

Yes.

Note that all those values are controlled by pref gfx.font_rendering.opentype_svg.enabled, and there is a test to ensure the effectiveness of that pref. So we probably need to follow that as well.

@nox
Copy link
Member

@nox nox commented Apr 22, 2017

@upsuper
Copy link
Member Author

@upsuper upsuper commented Apr 22, 2017

Why compat spec? It is nothing about compat, it is a feature we support and don't want to unship. It is just defined in OpenType spec rather than an SVG or CSS spec.

@nox
Copy link
Member

@nox nox commented Apr 22, 2017

@upsuper All I saw was the microsoft domain and I thought it was vendor-specific, disregard that. :)

@upsuper
Copy link
Member Author

@upsuper upsuper commented Apr 22, 2017

That is the OpenType spec hosted on Microsoft's domain. The original draft can be found here: https://dev.w3.org/SVG/modules/fonts/SVG-OpenType.html and there is a link saying the document in Microsoft domain is the spec.

IIRC this is actually something only Gecko implements at the moment.

@kuoe0
Copy link
Contributor

@kuoe0 kuoe0 commented Jun 5, 2017

I'm working on this issue on Bug 1338764.

@sviter
Copy link

@sviter sviter commented Oct 6, 2017

Is it still valid?

@upsuper
Copy link
Member Author

@upsuper upsuper commented Oct 6, 2017

This has been fixed by #17940.

@upsuper upsuper closed this Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.