Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dumping display list levels to rust log #1529

Merged
merged 1 commit into from Jan 24, 2014

Conversation

ibnc
Copy link

@ibnc ibnc commented Jan 22, 2014

No description provided.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/613

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@ibnc
Copy link
Author

ibnc commented Jan 22, 2014

r=metajack

@ibnc
Copy link
Author

ibnc commented Jan 23, 2014

Okay, so sort of the idea here was to implement display list dumping similar to flow tree dumping. Flow tree dumping does debug!("{:?}, layout_root.dump()); and I don't really think "{:?}" is avoidable here.

When I use debug!("{}" self.dump()); I get error: failed to find an implementation of trait std::fmt::Default for () I tried the approach of having two separately configured dump functions, but I don't see the display list dumped :/

@metajack
Copy link
Contributor

Fair enough. Keep it as {:?}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants