Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement parsing and serialization of grid properties #15307

Closed
upsuper opened this issue Jan 31, 2017 · 4 comments
Closed

Implement parsing and serialization of grid properties #15307

upsuper opened this issue Jan 31, 2017 · 4 comments
Assignees
@wafflespeanut
Labels
A-content/css A-stylo B-feature-tracking

Comments

@upsuper
Copy link
Member

@upsuper upsuper commented Jan 31, 2017 •
edited by wafflespeanut

Spec: https://drafts.csswg.org/css-grid/

Grid properties have relatively complicated syntax, so it might not be a very easy one.
@wafflespeanut
Copy link
Member

@wafflespeanut wafflespeanut commented Jan 31, 2017

Yeah, it's in my queue. I'm supposed to finish those by the start of this year 😛
@wafflespeanut wafflespeanut self-assigned this Jan 31, 2017
@Manishearth
Copy link
Member

@Manishearth Manishearth commented May 24, 2017

We seem to handle everything except grid and grid-template, which are both shorthands.

@wafflespeanut @canaltinova do you have time to fix those? if not I'll just finish them up
@wafflespeanut
Copy link
Member

@wafflespeanut wafflespeanut commented May 24, 2017

I have a patch for grid-template (will open a PR today). I'm fine with working on grid if @canaltinova has other interesting stuff to work on :)
@Manishearth
Copy link
Member

@Manishearth Manishearth commented May 24, 2017

okay, thanks. Probably best if you do grid, since it's pretty straightforward once you have grid-template.
@wafflespeanut wafflespeanut mentioned this issue May 24, 2017
Merged
bors-servo added a commit that referenced this issue May 25, 2017
@bors-servo
Auto merge of #17021 - servo:grid, r=nox
Loading status checks…
9e7f02b 
Stylo: Wrap up grid

Adds the final piece for grid (`grid-template` and `grid` shorthands), fixes #15307

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17021)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wafflespeanut wafflespeanut

Labels
A-content/css A-stylo B-feature-tracking
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Stylo: Wrap up grid
4 participants
@nox @upsuper @Manishearth @wafflespeanut
You can’t perform that action at this time.