Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine what data to store on a session history entry #15308

Closed
cbrewster opened this issue Jan 31, 2017 · 2 comments
Closed

Determine what data to store on a session history entry #15308

cbrewster opened this issue Jan 31, 2017 · 2 comments

Comments

@cbrewster
Copy link
Member

@cbrewster cbrewster commented Jan 31, 2017

We need to figure out what data we need to store on a session history entry and where to store it (script or constellation). This is needed for things such as the History API or properly reloading documents that have been pruned from the history.

Right now we have:

  • timestamp
  • url
  • pipeline id

As we move forward we need to store things such as:

  • origin (possible issues with serialization/mutability)
  • request type (GET, POST, etc...)
  • history state
  • hash change info (probably can be determined from url)
  • scroll location

We need to figure out what other data we need to store and the appropriate location for them. Ideally we should reduce managing the same state in multiple places.
cc @asajeffrey

@jdm
Copy link
Member

@jdm jdm commented Jan 31, 2017

This sounds really similar to #14888 (comment).

@cbrewster
Copy link
Member Author

@cbrewster cbrewster commented Jan 31, 2017

Ahh indeed! Forgot about that

@cbrewster cbrewster closed this Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.