Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement parsing and serialization for `grid-{row,column}-gap` #15310

Closed
wafflespeanut opened this issue Jan 31, 2017 · 5 comments
Closed

Implement parsing and serialization for `grid-{row,column}-gap` #15310

wafflespeanut opened this issue Jan 31, 2017 · 5 comments
Labels
A-content/css C-assigned E-easy

Comments

@wafflespeanut
Copy link
Member

@wafflespeanut wafflespeanut commented Jan 31, 2017

grid-row-gap and grid-column-gap both have the grammar <length> | <percentage>. We already support parsing LengthOrPercentage, so this can be accomplished with predefined_type.

See the guide for more information about implementing a predefined type property.

Code: components/style/properties/longhands/position.mako.rs
@highfive
Copy link

@highfive highfive commented Jan 31, 2017

Please make a comment here if you intend to work on this issue. Thank you!
@wafflespeanut wafflespeanut mentioned this issue Jan 31, 2017
Closed
5 of 5 tasks complete
@hiei23
Copy link
Contributor

@hiei23 hiei23 commented Feb 2, 2017

can i work on this ?
@jdm
Copy link
Member

@jdm jdm commented Feb 2, 2017

Please do! Ask questions if anything is unclear.
@KiChjang KiChjang added the C-assigned label Feb 2, 2017
@wafflespeanut
Copy link
Member Author

@wafflespeanut wafflespeanut commented Feb 7, 2017

@hiei23 have you started working on this?
@hiei23
Copy link
Contributor

@hiei23 hiei23 commented Feb 7, 2017

yes i have started. I am new to rust programming language and catching up with the language.
@hiei23 hiei23 mentioned this issue Feb 9, 2017
Merged
3 of 5 tasks complete
bors-servo added a commit that referenced this issue Feb 10, 2017
@bors-servo
Auto merge of #15466 - hiei23:master, r=Wafflespeanut
Loading status checks…
aea6797 
-added parsing and serialization for grid-{row,column}-gap

<!-- Please describe your changes on the following line: -->
I have added an implementation for grid-{row,column}-gap based on the predefined type property suggestion in the description

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #15310 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15466)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/css C-assigned E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

-added parsing and serialization for grid-{row,column}-gap
5 participants
@jdm @KiChjang @highfive @wafflespeanut @hiei23
You can’t perform that action at this time.