Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

color value should be canonicalized when serializing #15397

Closed
upsuper opened this issue Feb 6, 2017 · 0 comments
Closed

color value should be canonicalized when serializing #15397

upsuper opened this issue Feb 6, 2017 · 0 comments
Assignees
@canova
Labels
A-content/css
Milestone
Stylo: Style syst...

Comments

@upsuper
Copy link
Member

@upsuper upsuper commented Feb 6, 2017

For example:

  • CURRENTcolor should be serialized to currentcolor
  • RGB(0, 128, 0) should be serialized to rgb(0, 128, 0)

Test code:

<!DOCTYPE html>
<p style="background-color: CurrentCOLOR;">hello</p>
<script>
  alert(document.querySelector('p').style.backgroundColor);
</script>

Unfortunately there doesn't seem to be any spec for this algorithm, and I've filed w3c/csswg-drafts#1004 for that.

I guess this would need changes to both Servo and cssparser.
@upsuper upsuper mentioned this issue Feb 6, 2017
Closed
@canova canova mentioned this issue Jun 21, 2017
Merged
bors-servo added a commit to servo/rust-cssparser that referenced this issue Jun 21, 2017
@bors-servo
Auto merge of #162 - canaltinova:currentcolor, r=Manishearth
Loading status checks…
b351bbf 
Serialize currentcolor as canonicalized form

Serialize currentcolor as canonicalized form instead of currentColor. This is needed for servo/servo#15397
I'm not sure about version bump though. Is that a breaking change?

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/162)
<!-- Reviewable:end -->
@canova canova self-assigned this Jun 21, 2017
@canova canova mentioned this issue Jun 21, 2017
Merged
2 of 2 tasks complete
bors-servo added a commit that referenced this issue Jun 22, 2017
@bors-servo
Auto merge of #17461 - canaltinova:currentcolor, r=emilio
Loading status checks…
2414688 
Bump cssparser to 1.16.1

This will fix #15397

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17461)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@canova canova

Labels
A-content/css
Projects
None yet
Milestone
Stylo: Style syst...
Linked pull requests

Successfully merging a pull request may close this issue.

Bump cssparser to 1.16.1
2 participants
@upsuper @canova
You can’t perform that action at this time.