Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name of custom properties are not properly escaped when serializing #15399

Closed
upsuper opened this issue Feb 6, 2017 · 1 comment
Closed

Name of custom properties are not properly escaped when serializing #15399

upsuper opened this issue Feb 6, 2017 · 1 comment
Labels
A-content/css
Milestone
Stylo: Style syst...

Comments

@upsuper
Copy link
Member

@upsuper upsuper commented Feb 6, 2017

See the following test code:

<!DOCTYPE html>
<p style="--weird\;name: green">hello</p>
<script>
  alert(document.querySelector('p').style.cssText);
</script>

Servo currently shows --weird;name: green; which is wrong, because it is invalid. The name should be escaped so the result should be --weird\;name: green;.

Blink seems to have the same issue, so it's worth a new test in wpt.
@upsuper upsuper mentioned this issue Feb 6, 2017
Closed
@heycam
Copy link
Member

@heycam heycam commented May 3, 2017

Fixed by #16691.
@heycam heycam closed this May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/css
Projects
None yet
Milestone
Stylo: Style syst...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@upsuper @heycam
You can’t perform that action at this time.