Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FormData contains Root<File> in a field #15496

Open
Ms2ger opened this issue Feb 10, 2017 · 2 comments
Open

FormData contains Root<File> in a field #15496

Ms2ger opened this issue Feb 10, 2017 · 2 comments
Labels
A-content/dom I-memory-leak

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Feb 10, 2017

I'm pretty sure this leaks:

pub struct FormData {
    data: DOMRefCell<HashMap<LocalName, Vec<FormDatum>>>,
}
pub struct FormDatum {
    pub value: FormDatumValue
}
pub enum FormDatumValue {
    File(Root<File>),
}
@nox
Copy link
Member

@nox nox commented Feb 10, 2017

How does that leak anything?
@Ms2ger
Copy link
Contributor Author

@Ms2ger Ms2ger commented Feb 10, 2017

http://logs.glob.uno/?c=mozilla%23servo&s=10+Feb+2017&e=10+Feb+2017#c609664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom I-memory-leak
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Ms2ger @nox
You can’t perform that action at this time.