Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rustc builds without asserts #15548

Closed
jdm opened this issue Feb 14, 2017 · 6 comments
Closed

Use rustc builds without asserts #15548

jdm opened this issue Feb 14, 2017 · 6 comments
Assignees
@nox
Labels
A-mach I-perf-slow

Comments

@jdm
Copy link
Member

@jdm jdm commented Feb 14, 2017

The Rust team is making these builds available in the s3 bucket, so we need to modify the mach bootstrap command to fetch the appropriate URL to retrieve them. This is blocked until rust-lang/rust#39754 is merged.
@highfive
Copy link

@highfive highfive commented Feb 14, 2017

cc @wafflespeanut
@jdm
Copy link
Member Author

@jdm jdm commented Feb 14, 2017

https://s3.amazonaws.com/rust-lang-ci/rustc-builds-alt/$sha/$tarball is where they will reside.
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Feb 14, 2017

Maybe we want this for developers building locally, but keep LLVM assertions on CI?
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Feb 15, 2017

Or we could have LLVM assertions in "debug" CI builds, but not release ones. Are release jobs the longest in our current CI? Could we reduce the total cycle time if they’re faster?
@nox nox self-assigned this Feb 15, 2017
nox added a commit that referenced this issue Feb 15, 2017
@nox
Allow disabling LLVM assertions in rustc (fixes #15548)
Loading status checks…
5a63115
nox added a commit that referenced this issue Feb 15, 2017
@nox
Allow disabling LLVM assertions in rustc (fixes #15548)
Loading status checks…
7f8b429
nox added a commit that referenced this issue Feb 15, 2017
@nox
Allow disabling LLVM assertions in rustc (fixes #15548)
Loading status checks…
09d88cb
bors-servo added a commit that referenced this issue Feb 15, 2017
@bors-servo
Auto merge of #15559 - servo:rustup, r=SimonSapin
Loading status checks…
eec47bb 
Allow disabling LLVM assertions in rustc (fixes #15548)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15559)
<!-- Reviewable:end -->
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Feb 15, 2017 •
edited

On IRC:

@mbrubeck "mac-rel-css" jobs are currently taking about 54 minutes
@mbrubeck More than half that is compile time
@mbrubeck Maybe we could move the "build-geckolib" step to one of the "mac-rel-wpt" builders instead

Disabling LLVM assertions cuts release compile times by a third: #15559 (comment)
bors-servo added a commit that referenced this issue Feb 15, 2017
@bors-servo
Auto merge of #15559 - servo:rustup, r=SimonSapin
Loading status checks…
4f10a0f 
Allow disabling LLVM assertions in rustc (fixes #15548)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15559)
<!-- Reviewable:end -->
@SimonSapin SimonSapin mentioned this issue Feb 15, 2017
Merged
3 of 5 tasks complete
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Feb 15, 2017

Reopening since this is not yet enabled by default: #15564
@SimonSapin SimonSapin reopened this Feb 15, 2017
bors-servo added a commit that referenced this issue Feb 16, 2017
@bors-servo
Auto merge of #15564 - servo:no-gods-no-masters-no-assertions, r=<try>
Loading status checks…
9c549fb 
Do not merge yet: Disable LLVM assertions by default

<!-- Please describe your changes on the following line: -->

#15559 (comment)

> With an empty incremental compilation cache (or, presumably, with incremental compilation disabled), LLVM assertions add 16% to the compilation time in debug mode, 53% (!) in release mode.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15548 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15564)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 16, 2017
@bors-servo
Auto merge of #15564 - servo:no-gods-no-masters-no-assertions, r=<try>
Loading status checks…
5f14170 
Do not merge yet: Disable LLVM assertions by default, on supported platforms

<!-- Please describe your changes on the following line: -->

#15559 (comment)

> With an empty incremental compilation cache (or, presumably, with incremental compilation disabled), LLVM assertions add 16% to the compilation time in debug mode, 53% (!) in release mode.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15548 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15564)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 16, 2017
@bors-servo
Auto merge of #15564 - servo:no-gods-no-masters-no-assertions, r=<try>
Loading status checks…
921585a 
Do not merge yet: Disable LLVM assertions by default, on supported platforms

<!-- Please describe your changes on the following line: -->

#15559 (comment)

> With an empty incremental compilation cache (or, presumably, with incremental compilation disabled), LLVM assertions add 16% to the compilation time in debug mode, 53% (!) in release mode.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15548 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15564)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 17, 2017
@bors-servo
Auto merge of #15564 - servo:no-gods-no-masters-no-assertions, r=Ms2ger
Loading status checks…
1afae52 
Disable LLVM assertions by default, on supported platforms

<!-- Please describe your changes on the following line: -->

#15559 (comment)

> With an empty incremental compilation cache (or, presumably, with incremental compilation disabled), LLVM assertions add 16% to the compilation time in debug mode, 53% (!) in release mode.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15548 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15564)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nox nox

Labels
A-mach I-perf-slow
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Disable LLVM assertions by default, on supported platforms
4 participants
@jdm @nox @SimonSapin @highfive
You can’t perform that action at this time.