Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ArrayBufferViewContents trait #15551

Closed
jdm opened this issue Feb 14, 2017 · 3 comments
Closed

Remove ArrayBufferViewContents trait #15551

jdm opened this issue Feb 14, 2017 · 3 comments
Labels
A-content/bindings C-assigned E-easy I-cleanup

Comments

@jdm
Copy link
Member

@jdm jdm commented Feb 14, 2017

This trait no longer appears to be used after the work in #14672, so it should be possible to remove it.

Code: components/script/dom/bindings/conversions.rs

No need for automated tests; if the build succeeds, it's good enough for a PR.
@highfive
Copy link

@highfive highfive commented Feb 14, 2017

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄
@hgallagher1993
Copy link
Contributor

@hgallagher1993 hgallagher1993 commented Feb 14, 2017 •
edited

Ya i'll do this @highfive: assign me
@highfive highfive added the C-assigned label Feb 14, 2017
@highfive
Copy link

@highfive highfive commented Feb 14, 2017

Hey @hgallagher1993! Thanks for your interest in working on this issue. It's now assigned to you!
@Greeene Greeene mentioned this issue Feb 19, 2017
Merged
bors-servo added a commit that referenced this issue Feb 20, 2017
@bors-servo
Auto merge of #15650 - Greeene:rm_array_buffer_contents_trait, r=Simo…
Loading status checks…
82d05a0 
…nSapin

Remove ArrayBufferViewContents trait

<!-- Please describe your changes on the following line: -->
Removed ArrayBufferViewContents trait and dependent uses.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ x ] `./mach build -d` does not report any errors
- [ x ] `./mach test-tidy` does not report any errors
- [ x ] These changes fix #15551

<!-- Either: -->
- [ x ] These changes do not require tests because it's just unused trait and @jdm said, "No need for automated tests; if the build succeeds, it's good enough for a PR."

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15650)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/bindings C-assigned E-easy I-cleanup
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Remove ArrayBufferViewContents trait
3 participants
@jdm @highfive @hgallagher1993
You can’t perform that action at this time.