Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When an origin is opaque set the origin header to `null`. #15569

Closed
samgiles opened this issue Feb 15, 2017 · 8 comments
Closed

When an origin is opaque set the origin header to `null`. #15569

samgiles opened this issue Feb 15, 2017 · 8 comments
Labels
A-network

Comments

@samgiles
Copy link
Contributor

@samgiles samgiles commented Feb 15, 2017 •
edited

Once Hyper supports setting a null Origin header, update try_url_origin_to_hyper_origin in components/net/http_loader.rs to set Origin: null.

hyperium/hyper#1065
@samgiles samgiles mentioned this issue Feb 15, 2017
Closed
4 of 4 tasks complete
@jdm jdm added the A-network label Feb 15, 2017
@samgiles
Copy link
Contributor Author

@samgiles samgiles commented Feb 15, 2017

In the meantime, we can implement the Header trait from Hyper for url::Origin.

I can work on this.
samgiles added a commit to samgiles/servo that referenced this issue Feb 17, 2017
@samgiles
Bug servo#15569 - Serialize origins correctly when making requests
9a981b7
samgiles added a commit to samgiles/servo that referenced this issue Feb 17, 2017
@samgiles
Bug servo#15569 - Serialize origins correctly when making requests
10c0cd9
samgiles added a commit to samgiles/servo that referenced this issue Feb 17, 2017
@samgiles
Bug servo#15569 - Serialize origins correctly when making requests
16b758b
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Jul 2, 2017

This is done in #15903.
@KiChjang KiChjang closed this Jul 2, 2017
@pyfisch pyfisch mentioned this issue Jan 4, 2018
Open
4 of 13 tasks complete
@tigercosmos tigercosmos mentioned this issue Jan 7, 2018
Closed
0 of 5 tasks complete
@KiChjang KiChjang reopened this Jan 7, 2018
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Jan 7, 2018

Turns out this actually isn't fixed by #15903 yet, we need to upgrade our hyper to at least version 0.11 before we can fix this.
@tigercosmos
Copy link
Collaborator

@tigercosmos tigercosmos commented Jan 8, 2018

Could we upgrade hyper now? Or something block?
@jdm
Copy link
Member

@jdm jdm commented Jan 8, 2018

We are using the last version of hyper that did not include the async I/O API changes. We want to upgrade to the version that uses async I/O, but it's more work than previous hyper upgrades.
@Eijebong
Copy link
Member

@Eijebong Eijebong commented Oct 12, 2018

#21644
@atouchet
Copy link
Contributor

@atouchet atouchet commented Nov 2, 2018

Is this fixed now?
@Eijebong
Copy link
Member

@Eijebong Eijebong commented Nov 2, 2018

Oh, yeah, forgot about it, thanks :p
@Eijebong Eijebong closed this Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-network
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@jdm @samgiles @KiChjang @Eijebong @tigercosmos @atouchet
You can’t perform that action at this time.