Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace uses of JS_GetArrayBufferViewType with high-level API #15605

Closed
jdm opened this issue Feb 16, 2017 · 2 comments
Closed

Replace uses of JS_GetArrayBufferViewType with high-level API #15605

jdm opened this issue Feb 16, 2017 · 2 comments
Labels
A-content/dom C-assigned I-cleanup

Comments

@jdm
Copy link
Member

@jdm jdm commented Feb 16, 2017

We have code that invokes the JS_GetArrayBufferViewType API from SpiderMonkey. Once servo/rust-mozjs#340 merges, we can update the version of the js crate (./mach cargo-update -p js) and replace them with the new API added to the ArrayBufferView type.

Tests: ./mach test-wpt tests/wpt/web-platform-tests/WebCrypto and ./mach test-wpt tests/wpt/web-platform-tests/webgl should verify that there's no behavioural change.
@jdm jdm added the A-content/dom label Feb 16, 2017
@jdm
Copy link
Member Author

@jdm jdm commented Feb 16, 2017

@samliu Does this sound interesting to you?
@jdm jdm added the I-cleanup label Feb 16, 2017
@samliu
Copy link
Contributor

@samliu samliu commented Feb 16, 2017 •
edited

If I understand correctly, this is a cleanup task to replace JS_GetArrayBufferViewType usages with ArrayBufferView, which is an interface that reduces our dependency on this SpiderMonkey specific API.

That sounds like a great first task, please assign it to me. I'll try to have a patch in by this weekend :)
@jdm jdm added the C-assigned label Feb 16, 2017
@samliu samliu mentioned this issue Feb 20, 2017
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Feb 21, 2017
@bors-servo
Auto merge of #15653 - samliu:cleanup_arraybufferview_type, r=cbrewster
Loading status checks…
907c1ef 
Cleanup arraybufferview type

<!-- Please describe your changes on the following line: -->
Replace uses of spidermonkey-specific JS_GetArrayBufferViewType with ArrayBufferView impl's method get_array_type().

Tests pass:
./mach test-wpt tests/wpt/web-platform-tests/WebCrypto
./mach test-wpt tests/wpt/web-platform-tests/webgl

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15605 (github issue number if applicable).
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15653)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned I-cleanup
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Cleanup arraybufferview type
2 participants
@jdm @samliu
You can’t perform that action at this time.