Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove libservo API (WindowMethods and WindowEvent) #15645
Closed
Comments
|
Superseded by #15934 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is part of an effort to improve Servo's embedding story. See https://github.com/paulrouget/servoshell/projects/2
As of now, the embedder must implement the
WindowMethodstrait.I would split these methods in 4 groups:
I think we can offer a better API:
updateGeometry(AGeometryStruct)method.AGeometryStructwould include the scale factor, the inner size and the window position.As for
browser.handle_events, it acceptsWindowEvent. Not everything is a window event. We need a better semantic here. MaybeServoCommand.