Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually include file with marker shorthand #15646

Merged
merged 1 commit into from Feb 19, 2017

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Feb 19, 2017

This wasn't being included so nothing was actually happening.

r? @heycam or @mbrubeck


This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/shorthand/inherited_svg.mako.rs, components/style/properties/properties.mako.rs
  • @emilio: components/style/properties/shorthand/inherited_svg.mako.rs, components/style/properties/properties.mako.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 19, 2017
@heycam
Copy link
Contributor

heycam commented Feb 19, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 1541a2d has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 19, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 1541a2d with merge d88e275...

bors-servo pushed a commit that referenced this pull request Feb 19, 2017
Actually include file with marker shorthand

This wasn't being included so nothing was actually happening.

r? @heycam or @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15646)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: heycam
Pushing d88e275 to master...

@bors-servo bors-servo merged commit 1541a2d into servo:master Feb 19, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 19, 2017
@Manishearth Manishearth deleted the marker branch May 7, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants