Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAsk the embedder the permission to navigate #15655
Closed
Comments
bors-servo
added a commit
that referenced
this issue
Mar 14, 2017
Let the embedder decide if servo should follow a link or not We want to give a chance to the embedder to handle a link itself. Is it a problem that this will add a round trip to the main thread every time `load_url` is called? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #15655 <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because I'm not sure how to test that <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15795) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is part of an effort to improve Servo's embedding story. See https://github.com/paulrouget/servoshell/projects/2
We want the embedder to have the ability to prevent navigation. For example, if the embedder wants to open "http://reddit.com" link in a different browser, it needs to be able to cancel the navigation and handle the URL itself.