Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinning Spheres demo is no longer fluid #15687

Open
jdm opened this issue Feb 22, 2017 · 7 comments
Open

Spinning Spheres demo is no longer fluid #15687

jdm opened this issue Feb 22, 2017 · 7 comments
Labels

Comments

@jdm
Copy link
Member

@jdm jdm commented Feb 22, 2017

./mach run --release https://cdn.rawgit.com/servo/servo.org/gh-pages/bhtml-newtab/webrender-demos/spheres.html no longer feels smooth in Servo.

@jdm jdm added the I-perf-slow label Feb 22, 2017
@glennw
Copy link
Member

@glennw glennw commented Feb 22, 2017

I did a few tests and it doesn't appear to be rendering related. Of note:

  • The render threads and GPU times are well under the 60 fps threshold (16.67ms).
  • The frame rate is > 60 fps (with vsync disabled), but still a lot lower than the renderer is running at (perhaps limited by layout / style?).
  • The jank itself seems unrelated to the framerate, since it is running above 60 fps.

slow

@boustrophedon
Copy link

@boustrophedon boustrophedon commented Feb 24, 2017

This demo appears to render the same for Servo and Chromium for me. The spheres are "wobbly" in both, though somewhat more in Servo for some reason. Firefox has an extremely low framerate for some reason.

I'd be interested in debugging this if someone can tell me what I'm looking for. Also, can I just do a git bisect inside the servo directory or do I have to do something more because of mach?

@jdm
Copy link
Member Author

@jdm jdm commented Feb 25, 2017

A git bisect should work.

@boustrophedon
Copy link

@boustrophedon boustrophedon commented Feb 25, 2017

Okay! So what am I looking for? Less wobbly spheres?

@jdm
Copy link
Member Author

@jdm jdm commented Feb 25, 2017

I'm not sure what you mean by wobbly, but in a release build last July the motion was very fluid.

@boustrophedon
Copy link

@boustrophedon boustrophedon commented Feb 25, 2017

I'll take a video of what I see on my computer, because it seems like we might be seeing different things.

@boustrophedon
Copy link

@boustrophedon boustrophedon commented Feb 26, 2017

Here is a video showing what I see with checkout at 5dac1f6, from the last bors commit I found in July.

Here is a video showing what I see with checkout at 26de7c6, that I checked out yesterday.

Both were recorded with recordMyDesktop at 50fps because for some reason it doesn't want to record above that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.