Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pool HTTP connections. #15696

Merged
merged 1 commit into from Feb 23, 2017
Merged

Do not pool HTTP connections. #15696

merged 1 commit into from Feb 23, 2017

Conversation

jdm
Copy link
Member

@jdm jdm commented Feb 22, 2017

HTTP connection pooling triggers consistent failures in #14620. Let's disable it until there's more time to solve the underlying problem in #15694.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/resource_thread.rs

@highfive
Copy link

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 22, 2017
@jdm
Copy link
Member Author

jdm commented Feb 22, 2017

@bors-servo: try

@bors-servo
Copy link
Contributor

⌛ Trying commit 3258cff with merge 3ae9ca3...

bors-servo pushed a commit that referenced this pull request Feb 22, 2017
Do not pool HTTP connections.

HTTP connection pooling triggers consistent failures in #14620. Let's disable it until there's more time to solve the underlying problem in #15694.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes
@emilio
Copy link
Member

emilio commented Feb 23, 2017

This looks sensible to me given the explanations. r=me when needed.

@jdm
Copy link
Member Author

jdm commented Feb 23, 2017

@bors-servo: r=emilio

@highfive highfive assigned emilio and unassigned Manishearth Feb 23, 2017
@bors-servo
Copy link
Contributor

💥 Test timed out

@nox
Copy link
Contributor

nox commented Feb 23, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Trying commit 3258cff with merge 3e6c200...

bors-servo pushed a commit that referenced this pull request Feb 23, 2017
Do not pool HTTP connections.

HTTP connection pooling triggers consistent failures in #14620. Let's disable it until there's more time to solve the underlying problem in #15694.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15696)
<!-- Reviewable:end -->
@nox
Copy link
Contributor

nox commented Feb 23, 2017

Oh, why did you try again Homu...

@bors-servo
Copy link
Contributor

💔 Test failed - arm32

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Feb 23, 2017
@nox
Copy link
Contributor

nox commented Feb 23, 2017

@bors-servo try- r=emilio

@bors-servo
Copy link
Contributor

📌 Commit 3258cff has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-tests-failed The changes caused existing tests to fail. labels Feb 23, 2017
@nox
Copy link
Contributor

nox commented Feb 23, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 3258cff with merge a780f6f...

bors-servo pushed a commit that referenced this pull request Feb 23, 2017
Do not pool HTTP connections.

HTTP connection pooling triggers consistent failures in #14620. Let's disable it until there's more time to solve the underlying problem in #15694.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15696)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt2

@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 23, 2017
@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Feb 23, 2017
@nox
Copy link
Contributor

nox commented Feb 23, 2017

@bors-servo retry #15705

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt2...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: emilio
Pushing a780f6f to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants