Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSpurious .DS_Store entries when running ./mach update-manifest on macOS #15725
Comments
nox
commented
Feb 24, 2017
•
|
|
|
I'll take a stab at this one |
|
#16562 was the last attempt, and it contained a suggestion for how to improve it. |
|
I can work on this if I can get some guidance. |
|
@anrdh Sure! The problem is that |
|
Since there is no asignee, can I work on this? |
|
@kregoslup Yes. |
Issue #15723: Skip git ignored files in update-manifest. <!-- Please describe your changes on the following line: --> This patch makes "./mach update-manifest" aware of .gitignore. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15725 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because I don't know how to test it, I have tried mocking opening file and checking whether it exists but it's difficult to handle both in py2.7 and py3 and I think it would say too much about `PathFilter` internals. I have also tried mocking `PathFilter` but then I would be duplicating logic in tests. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19550) <!-- Reviewable:end -->