Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse_origin fails to parse `center left` and `center right` #15750

Closed
upsuper opened this issue Feb 27, 2017 · 1 comment
Closed

parse_origin fails to parse `center left` and `center right` #15750

upsuper opened this issue Feb 27, 2017 · 1 comment
Assignees
@nox
Labels
A-content/css C-assigned
Milestone
Stylo: test_value...

Comments

@upsuper
Copy link
Member

@upsuper upsuper commented Feb 27, 2017

For transform-origin and perspective-origin, when the value consists of two keywords, the order of the values doesn't matter, and thus center left should just behave the same as left center.

Currently parse_origin always treat the first center as horizontal value if no horizontal value is parsed, thus it consider the second horizontal value to be invalid, which is wrong.

This bug is uncovered by change in #15613.
@upsuper
Copy link
Member Author

@upsuper upsuper commented Feb 27, 2017 •
edited

I suspect whether we really should fix parse_origin. I guess it is probably better having those properties use Position given the spec. But that may need Gecko side change to follow the spec as well.
@nox nox self-assigned this Apr 13, 2017
nox added a commit to nox/servo that referenced this issue Apr 13, 2017
@nox
Fix parsing or "center left" in parse_origin (fixes servo#15750)
ea7facd
@nox nox added the C-assigned label Apr 13, 2017
bors-servo added a commit that referenced this issue Apr 14, 2017
@bors-servo
Auto merge of #16435 - nox:parse-origin, r=emilio
Loading status checks…
f7896fd 
Fix parsing of "center left" in parse_origin (fixes #15750)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16435)
<!-- Reviewable:end -->
stshine added a commit to stshine/servo that referenced this issue Apr 14, 2017
@nox @stshine
Fix parsing of "center left" in parse_origin (fixes servo#15750)
e6a6148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nox nox

Labels
A-content/css C-assigned
Projects
None yet
Milestone
Stylo: test_value...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@nox @upsuper
You can’t perform that action at this time.