Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't serialize shorthand if some but not all its longhands have CSS-wide keyword #15779

Merged
merged 5 commits into from Mar 2, 2017

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented Mar 1, 2017

This also changes LonghandsToSerialize to store references to specified value directly rather than declared value, which significantly simplify many serialization code.


This change is Reviewable

@highfive
Copy link

highfive commented Mar 1, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/shorthand/background.mako.rs, components/style/properties/shorthand/mask.mako.rs, components/style/properties/shorthand/box.mako.rs, components/style/properties/helpers/animated_properties.mako.rs, components/style/custom_properties.rs, components/style/properties/shorthand/serialize.mako.rs, components/style/properties/shorthand/inherited_text.mako.rs, components/style/properties/shorthand/text.mako.rs, components/style/properties/shorthand/column.mako.rs, components/style/properties/shorthand/position.mako.rs, components/style/properties/helpers.mako.rs, components/style/properties/shorthand/font.mako.rs, components/style/properties/shorthand/border.mako.rs, components/style/properties/shorthand/inherited_svg.mako.rs, components/style/properties/shorthand/list.mako.rs, components/style/properties/properties.mako.rs, components/style/properties/shorthand/outline.mako.rs
  • @emilio: components/style/properties/shorthand/background.mako.rs, components/style/properties/shorthand/mask.mako.rs, components/style/properties/shorthand/box.mako.rs, components/style/properties/helpers/animated_properties.mako.rs, components/style/custom_properties.rs, components/style/properties/shorthand/serialize.mako.rs, components/style/properties/shorthand/inherited_text.mako.rs, components/style/properties/shorthand/text.mako.rs, components/style/properties/shorthand/column.mako.rs, components/style/properties/shorthand/position.mako.rs, components/style/properties/helpers.mako.rs, components/style/properties/shorthand/font.mako.rs, components/style/properties/shorthand/border.mako.rs, components/style/properties/shorthand/inherited_svg.mako.rs, components/style/properties/shorthand/list.mako.rs, components/style/properties/properties.mako.rs, components/style/properties/shorthand/outline.mako.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 1, 2017
@upsuper
Copy link
Contributor Author

upsuper commented Mar 1, 2017

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 684f486 with merge 6a4e8b8...

bors-servo pushed a commit that referenced this pull request Mar 1, 2017
[WIP] Don't serialize shorthand if some but not all its longhands have CSS-wide keyword

This also changes `LonghandsToSerialize` to store references to specified value directly rather than declared value, which significantly simplify many serialization code.
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
State: approved= try=True

@upsuper
Copy link
Contributor Author

upsuper commented Mar 1, 2017

r? @Manishearth

@upsuper upsuper changed the title [WIP] Don't serialize shorthand if some but not all its longhands have CSS-wide keyword Don't serialize shorthand if some but not all its longhands have CSS-wide keyword Mar 1, 2017
@emilio
Copy link
Member

emilio commented Mar 1, 2017

r=me when rebased

Rather than having separate variant for each CSS-wide keyword.
…CSS-wide keyword

Shorthand cannot represent CSS-wide keyword in individual longhands, and
thus we cannot serialize longhand with CSS-wide keyword as part of a
shorthand.
@upsuper
Copy link
Contributor Author

upsuper commented Mar 2, 2017

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit 4bc0fbe has been approved by emilio

@highfive highfive assigned emilio and unassigned Manishearth Mar 2, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 2, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 4bc0fbe with merge c87524c...

bors-servo pushed a commit that referenced this pull request Mar 2, 2017
Don't serialize shorthand if some but not all its longhands have CSS-wide keyword

This also changes `LonghandsToSerialize` to store references to specified value directly rather than declared value, which significantly simplify many serialization code.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15779)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: emilio
Pushing c87524c to master...

@bors-servo bors-servo merged commit 4bc0fbe into servo:master Mar 2, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 2, 2017
bors-servo pushed a commit that referenced this pull request Mar 2, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.
bors-servo pushed a commit that referenced this pull request Mar 2, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 2, 2017
…rvo/servo#15779.

--HG--
extra : rebase_source : a8b7ded88c6af24658ac2d23a036834b5d022209
bors-servo pushed a commit that referenced this pull request Mar 2, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this pull request Mar 3, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this pull request Mar 3, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this pull request Mar 3, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this pull request Mar 3, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this pull request Mar 3, 2017
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793)
<!-- Reviewable:end -->
Manishearth pushed a commit to Manishearth/gecko-dev that referenced this pull request Mar 13, 2017
JerryShih pushed a commit to JerryShih/gecko-dev that referenced this pull request Mar 13, 2017
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
…rvo/servo#15779.

UltraBlame original commit: 2e877886c769b49574a6af5ceeac16ccbc50d4cb
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
…rvo/servo#15779.

UltraBlame original commit: 2e877886c769b49574a6af5ceeac16ccbc50d4cb
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
…rvo/servo#15779.

UltraBlame original commit: 2e877886c769b49574a6af5ceeac16ccbc50d4cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants