New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't serialize shorthand if some but not all its longhands have CSS-wide keyword #15779
Conversation
Heads up! This PR modifies the following files:
|
@bors-servo try |
[WIP] Don't serialize shorthand if some but not all its longhands have CSS-wide keyword This also changes `LonghandsToSerialize` to store references to specified value directly rather than declared value, which significantly simplify many serialization code.
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev |
r? @Manishearth |
r=me when rebased |
Rather than having separate variant for each CSS-wide keyword.
…CSS-wide keyword Shorthand cannot represent CSS-wide keyword in individual longhands, and thus we cannot serialize longhand with CSS-wide keyword as part of a shorthand.
This significantly simplify the code.
@bors-servo r=emilio |
📌 Commit 4bc0fbe has been approved by |
Don't serialize shorthand if some but not all its longhands have CSS-wide keyword This also changes `LonghandsToSerialize` to store references to specified value directly rather than declared value, which significantly simplify many serialization code. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15779) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev |
Fix animation shorthand parsing which is somehow broken after #15779. But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec. I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.
Fix animation shorthand parsing which is somehow broken after #15779. But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec. I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793) <!-- Reviewable:end -->
…rvo/servo#15779. --HG-- extra : rebase_source : a8b7ded88c6af24658ac2d23a036834b5d022209
Fix animation shorthand parsing which is somehow broken after #15779. But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec. I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793) <!-- Reviewable:end -->
Fix animation shorthand parsing which is somehow broken after #15779. But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec. I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793) <!-- Reviewable:end -->
Fix animation shorthand parsing which is somehow broken after #15779. But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec. I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793) <!-- Reviewable:end -->
Fix animation shorthand parsing which is somehow broken after #15779. But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec. I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793) <!-- Reviewable:end -->
Fix animation shorthand parsing which is somehow broken after #15779. But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec. I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793) <!-- Reviewable:end -->
Fix animation shorthand parsing which is somehow broken after #15779. But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec. I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793) <!-- Reviewable:end -->
…rvo/servo#15779. UltraBlame original commit: 2e877886c769b49574a6af5ceeac16ccbc50d4cb
…rvo/servo#15779. UltraBlame original commit: 2e877886c769b49574a6af5ceeac16ccbc50d4cb
…rvo/servo#15779. UltraBlame original commit: 2e877886c769b49574a6af5ceeac16ccbc50d4cb
This also changes
LonghandsToSerialize
to store references to specified value directly rather than declared value, which significantly simplify many serialization code.This change is