Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix case sensitivity in cookie domains #15789
Open
Labels
Comments
bors-servo
added a commit
that referenced
this issue
Mar 7, 2017
Assert that `domain_match` is operating on lowercase text > (Note that both the domain string and the string will have been > canonicalized to lower case at this point.) Related to #15789 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15844) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Mar 7, 2017
Assert that `domain_match` is operating on lowercase text > (Note that both the domain string and the string will have been > canonicalized to lower case at this point.) Related to #15789 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15844) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Mar 8, 2017
Assert that `domain_match` is operating on lowercase text > (Note that both the domain string and the string will have been > canonicalized to lower case at this point.) Related to #15789 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15844) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Mar 9, 2017
Assert that `domain_match` is operating on lowercase text > (Note that both the domain string and the string will have been > canonicalized to lower case at this point.) Related to #15789 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15844) <!-- Reviewable:end -->
clementmiao
added a commit
to clementmiao/servo
that referenced
this issue
Apr 7, 2017
> (Note that both the domain string and the string will have been > canonicalized to lower case at this point.) Related to servo#15789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In tests/unit/net/cookie_http_state.rs::test_domain0026, the test is run with the domain 'home.eXaMpLe.org.' After #15775, this test fails because of case sensitivity in components/net/cookie.rs::domain_match and components/net/cookie_storage.rs::reg_host.