Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit ImageData code #15823

Open
nox opened this issue Mar 5, 2017 · 3 comments
Open

Audit ImageData code #15823

nox opened this issue Mar 5, 2017 · 3 comments

Comments

@nox
Copy link
Member

@nox nox commented Mar 5, 2017

Things such as let len = width * height * 4; without any explicit overflow checking scares me.

@hgluka
Copy link

@hgluka hgluka commented Mar 5, 2017

Hey, is it ok if I try to do this one? I'd have to ask you a few clarifying questions, but I think I can handle it, even though I'm a beginner in Rust.

@hgluka
Copy link

@hgluka hgluka commented Mar 10, 2017

I looked into it myself, but I was wondering if there was a particular reason that width and height are u32, but get_size returns Size2D<i32>?

@jdm
Copy link
Member

@jdm jdm commented Mar 20, 2017

@lucantrop Probably because the particular caller that needed the size worked best in those units.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.