Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WR (scroll root changes, border gradients, yuv updates). #15879

Merged
merged 1 commit into from Mar 9, 2017
Merged

Update WR (scroll root changes, border gradients, yuv updates). #15879

merged 1 commit into from Mar 9, 2017

Conversation

glennw
Copy link
Member

@glennw glennw commented Mar 9, 2017 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

highfive commented Mar 9, 2017

Heads up! This PR modifies the following files:

  • @emilio: components/layout/webrender_helpers.rs

@highfive
Copy link

highfive commented Mar 9, 2017

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 9, 2017
@glennw
Copy link
Member Author

glennw commented Mar 9, 2017

r? @mrobinson

This seems straightforward - but it would be good if @mrobinson could just verify the API change for scroll layer IDs is correct.

@highfive highfive assigned mrobinson and unassigned mbrubeck Mar 9, 2017
@mrobinson
Copy link
Member

Yep! Looks good to me.

@mrobinson
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit ce49bc5 has been approved by mrobinson

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 9, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit ce49bc5 with merge 802440d...

bors-servo pushed a commit that referenced this pull request Mar 9, 2017
Auto merge of #15879 - glennw:update-wr-scroll, r=mrobinson
802440d 
Update WR (scroll root changes, border gradients, yuv updates).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15879)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: mrobinson
Pushing 802440d to master...

@bors-servo bors-servo merged commit ce49bc5 into servo:master Mar 9, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mrobinson mrobinson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@glennw @highfive @mrobinson @bors-servo @mbrubeck @gw3583