Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHTMLImageElement::handle_event should use a for loop #15885
Closed
Labels
Comments
|
Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the If you intend to work on this issue, then add |
|
I'll take this @highfive: assign me |
|
Hey @hgallagher1993! Thanks for your interest in working on this issue. It's now assigned to you! |
|
@highfive assign me |
|
It looks like this has already been assigned to someone. I'll leave the decision to a core contributor. |
bors-servo
added a commit
that referenced
this issue
Mar 10, 2017
Change while loop in HTMLImageElement::handle_event to for loop <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15885 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because @Ms2ger said none were needed <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15892) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code:
components/script/dom/htmlimageelement.rsIt uses
I don't see any reason it can't use
for element in elements {}Doesn't need a test; if it compiles, that's good enough.