Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement border gradient support. #15894
Closed
Comments
bors-servo
added a commit
that referenced
this issue
May 1, 2017
Improvements to gradients. This is a collection of commits improving the rendering of linear and radial gradients by making them conform more closely to the spec. All commits are are independent and should work without the others. These commits address the following issues: * a956e3f resolves #3908 but contains also some other necessary changes to `convert_gradient_stops`. The updated function has a few more copys but should be more correct. Maybe @pcwalton wants to comment since he has originally written the code. * b230be8 partially solves #16638. (Partially because `border-image-outset` is not implemented. This is an older issue for border gradients: #15894. To quickly catch regressions and see changes to gradients I have created [a set of twelve manual testcases](https://pyfisch.org/stuff/testcases-gradients.html) and placed them in a single file. Attached are two files. One shows how the gradients were rendered before the PR the other one with the changes applied.   r? @emilio and maybe also @jdm? --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16666) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 7, 2017
Improvements to gradients. This is a collection of commits improving the rendering of linear and radial gradients by making them conform more closely to the spec. All commits are are independent and should work without the others. These commits address the following issues: * a956e3f resolves #3908 but contains also some other necessary changes to `convert_gradient_stops`. The updated function has a few more copys but should be more correct. Maybe @pcwalton wants to comment since he has originally written the code. * b230be8 partially solves #16638. (Partially because `border-image-outset` is not implemented. This is an older issue for border gradients: #15894. To quickly catch regressions and see changes to gradients I have created [a set of twelve manual testcases](https://pyfisch.org/stuff/testcases-gradients.html) and placed them in a single file. Attached are two files. One shows how the gradients were rendered before the PR the other one with the changes applied.   r? @emilio and maybe also @jdm? --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16666) <!-- Reviewable:end -->
|
Now linear and repeating gradients are supported except for the This should probably be closed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rendering support for this landed in a recent WR update. So this should mostly be connecting the style properties up in the display list builder.