Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a TiledImageLayer instead of one ImageLayer per tile #159

Closed
pcwalton opened this issue Oct 26, 2012 · 3 comments
Closed

Use a TiledImageLayer instead of one ImageLayer per tile #159

pcwalton opened this issue Oct 26, 2012 · 3 comments

Comments

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Oct 26, 2012

It's cleaner that way and will help us keep the division straight when we have multiple RenderLayers.

@dhedlund
Copy link
Contributor

@dhedlund dhedlund commented Dec 9, 2013

This may no longer be relevant due to substantial code changes, partially documented in #158. If still relevant, the description may need to be updated.

@metajack
Copy link
Contributor

@metajack metajack commented Dec 9, 2013

The basic idea is still valid with the new code. Right now we make one TextureLayer for each tile but we could group them in a TiledLayer. Off the top of my head, this still seems like something we should do. @pcwalton do you feel the same way?

ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
The older tree is inserted into <shadow>
@zwarich
Copy link

@zwarich zwarich commented Sep 27, 2014

This has been done since this bug was filed.

@zwarich zwarich closed this Sep 27, 2014
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.