Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename element field of Text and Comment to characterdata #1594

Closed
jdm opened this issue Jan 30, 2014 · 1 comment
Closed

Rename element field of Text and Comment to characterdata #1594

jdm opened this issue Jan 30, 2014 · 1 comment
Labels
A-content/dom E-easy

Comments

@jdm
Copy link
Member

@jdm jdm commented Jan 30, 2014

It's incorrectly named right now; all other DOM types name the parent field after the actual type.
@brunoabinader
Copy link
Contributor

@brunoabinader brunoabinader commented Feb 5, 2014

This needs to be updated with characterdata also for ProcessingInstruction after #1620 merges.
@quandrum quandrum mentioned this issue Feb 15, 2014
Merged
bors-servo pushed a commit that referenced this issue Feb 16, 2014
bors-servo
auto merge of #1702 : quandrum/servo/element_to_characterdata, r=jdm
a0b55b4 
... to characterdata

All other node's parent type names reflect the actual type of the parent. This change extends that convention to the indicated nodes.

closes #1594
therealglazou added a commit to therealglazou/servo that referenced this issue Feb 20, 2014
Adam Sinnett @therealglazou
Change Text, Comment and ProcessingInstructions parent name from elem…
f7e8479 
…ent to characterdata

All other node's parent type names reflect the actual type of the parent. This change extends that convention to the indicated nodes.

closes servo#1594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Change Text, Comment and ProcessingInstructions parent name from element...
2 participants
@jdm @brunoabinader
You can’t perform that action at this time.