PartialEq impl of SpecifiedUrl value is wrong for stylo #15950

upsuper · 2017-03-15T04:52:00Z

Serialization of shorthand marker depends on equality of url, and it fails when the url are set in different CSSOM call.

Specifically, the following code shows the problem:

<!DOCTYPE HTML>
<p style='marker-start: url("#a"); marker-mid: url("#a"); marker-end: url("#a");'></p>
<script>
let $p = document.querySelector('p');
alert($p.style.marker); // returns `url("#a")`
let a = "url(#a)"
$p.style.markerStart = a;
$p.style.markerMid = a;
$p.style.markerEnd = a;
alert($p.style.marker); // returns empty string
</script>

because it relies on the equality of urls:

servo/components/style/properties/shorthand/inherited_svg.mako.rs

Line 25 in de42121

if self.marker_start == self.marker_mid && self.marker_mid == self.marker_end {

but the equality of urls depends on equality of UrlExtraData which contains different pointers for each CSSOM call.

This probably should be fixed as part of the next change of how URL is implemented for stylo. File this issue just for a record.

upsuper · 2017-05-24T05:33:51Z

This seem to have been fixed.

upsuper added the A-stylo label Mar 15, 2017

upsuper added this to the Stylo: Style system mochitests milestone Mar 15, 2017

upsuper closed this May 24, 2017

servo / servo

PartialEq impl of SpecifiedUrl value is wrong for stylo #15950

PartialEq impl of SpecifiedUrl value is wrong for stylo #15950

upsuper commented Mar 15, 2017

upsuper commented May 24, 2017

servo / servo

Join GitHub today

PartialEq impl of SpecifiedUrl value is wrong for stylo #15950

PartialEq impl of SpecifiedUrl value is wrong for stylo #15950

Comments

upsuper commented Mar 15, 2017

upsuper commented May 24, 2017