Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement parsing and serialization of shape-outside property #15958

Closed
upsuper opened this issue Mar 15, 2017 · 5 comments
Closed

Implement parsing and serialization of shape-outside property #15958

upsuper opened this issue Mar 15, 2017 · 5 comments
Assignees
@canova
Labels
A-content/css A-stylo
Milestone
Stylo: test_value...

Comments

@upsuper
Copy link
Member

@upsuper upsuper commented Mar 15, 2017

Spec: https://drafts.csswg.org/css-shapes/#shape-outside-property

It should be added into https://github.com/servo/servo/blob/master/components/style/properties/longhand/box.mako.rs
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Mar 15, 2017

@hgallagher1993 Perhaps this would also interest you as well?
@hgallagher1993
Copy link
Contributor

@hgallagher1993 hgallagher1993 commented Mar 16, 2017

Ya I could take this 👍
@KiChjang KiChjang added the C-assigned label Mar 16, 2017
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Mar 16, 2017

Great! Sorry for the confusion earlier.
@bholley bholley added the A-stylo label Mar 26, 2017
@highfive
Copy link

@highfive highfive commented Mar 26, 2017

cc @emilio
@hgallagher1993
Copy link
Contributor

@hgallagher1993 hgallagher1993 commented Mar 31, 2017

@KiChjang I've had a couple of looks at this but I haven't found the time to actually do it and I don't think I will get the chance because I've had a heap of college work thrown on top of me the last week or 2 so it'd probably be better to un-assign me and leave it for someone else that has the time
@jdm jdm removed the C-assigned label Mar 31, 2017
@canova canova self-assigned this Apr 11, 2017
@canova canova mentioned this issue Apr 12, 2017
Merged
3 of 3 tasks complete
bors-servo added a commit that referenced this issue Apr 13, 2017
@bors-servo
Auto merge of #16384 - canaltinova:shape-outside, r=Manishearth
Loading status checks…
9d5dde2 
stylo: Implement shape-outside property

shape-outside property implemented.
r=Manishearth in bugzilla

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15958 and [Bug 1355003](https://bugzilla.mozilla.org/show_bug.cgi?id=1355003)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16384)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@canova canova

Labels
A-content/css A-stylo
Projects
None yet
Milestone
Stylo: test_value...
Linked pull requests

Successfully merging a pull request may close this issue.

stylo: Implement shape-outside property
7 participants
@jdm @upsuper @bholley @canova @KiChjang @highfive @hgallagher1993
You can’t perform that action at this time.