Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement parsing and serialization of initial-letter property #15959
Comments
|
Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the If you intend to work on this issue, then add |
|
I would like to work on this. @highfive: assign me |
|
Hey @karan1276! Thanks for your interest in working on this issue. It's now assigned to you! |
|
@karan1276 Have you made any progress on this? |
|
@wafflespeanut not yet. I'll look into it tomorrow |
|
cc @emilio |
|
This would have been a fun issue to do, but i don't want to block it for too long. I have some other issues in the pipe. Someone else can work on this issue if they wish so. |
|
I would like to work on this then, tough I probably need some guidance. @highfive: assign me |
|
Hey @streichgeorg! Thanks for your interest in working on this issue. It's now assigned to you! |
|
Please ask questions about anything that is unclear! |
|
So in the spec it says that the property takes the size, sink as numbers of lines, now for the computed value should I keep these values as numbers or do I already have to convert them to appunits. |
|
Keeping them in numbers should be the right way. |
initial-letter property <!-- Please describe your changes on the following line: --> Implemented parsing and serialization for the initial-letter property. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15959 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16166) <!-- Reviewable:end -->
…etter property
Spec: https://drafts.csswg.org/css-inline/#sizing-drop-initials
This should be added into https://github.com/servo/servo/blob/master/components/style/properties/longhand/text.mako.rs
See https://github.com/servo/servo/wiki/Property-hacking-guide for a guide to hack on this issue.