Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable tinyfiledialog popups when running in headless mode #15965
Assignees
Labels
Comments
bors-servo
added a commit
that referenced
this issue
Mar 16, 2017
Disabled tinyfiledialogs when running headless <!-- Please describe your changes on the following line: --> Disable tinyfiledialogs when running in headless mode. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15965 and #15962. - [X] These changes do not require tests because we don't test tinyfiledialog pop-ups. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15967) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we still pop up tinyfiledialogs in headless mode, which we shouldn't. This would fix #15962.