text-shadow should not accept negative value for its third length

[upsuper]

I thought it should be fixed in #15611 but apparently it didn't.

It seems text-shadow doesn't actually use Shadow::parse, but it is probably better have it share the same parsing code.

If we want to keep the SpecifiedTextShadow struct rather than using Shadow (for saving memory?), it is probably better having a conversion function from Shadow to that, rather than having separate parsing code.

@karan1276, since you worked on #15490, would you like to have a look at this issue as well?

[karan1276]

@upsuper sure, why not.

[upsuper]

Thanks.

[highfive]

cc @emilio

[karan1276]

I am going out of town for a week. Once i get back i will start work on this

[karan1276]

I was looking at the code. I have a few questions. Didn't we implement Shadow so properties like this can call it? or is there another use for it.
About the conversion system, how exactly should i go about it?

The structure of SpecifiedTextShadow and Shadow is almost same. Wouldn't it be better to use the Shadow object and call the Shadow::parse method (just guessing) ?

[karan1276]

@highfive: assign me

[highfive]

Hey @karan1276! Thanks for your interest in working on this issue. It's now assigned to you!

[upsuper]

The structure of SpecifiedTextShadow and Shadow is almost same. Wouldn't it be better to use the Shadow object and call the Shadow::parse method (just guessing) ?

That was my suggestion at the top of the issue as well.

[karan1276]

okay ill make changes and send pr. Ill probably get it wrong the first time, but lets see

[upsuper]

This seem to have been fixed.