Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport parsing moz-specific matrix functions in prefixed transform property #16003
Comments
bors-servo
added a commit
that referenced
this issue
Apr 19, 2017
stylo: Implement -moz-transform property -moz-transform property is an alias shorthand property. It has transform as sub-property but their parsing is different in some cases(matrix/matrix3d). -moz-transform also accepts LengthOrPercentage in the nondiagonal homogeneous components of matrix and matrix3d. It looks like length and percentage values are getting computed to number directly. For example 120px converts into 120 and calc(120px + 20%) converts into 140. So I did like this. But we need to check this behavior again to be sure, I guess. Also I spent half day investigating why matrices are not serializing after this change and found out their ToCss functions is not completely implemented yet😄 I was going to implement them but there is an easy issue about it(#15194) so I left it that way. Probably all tests won't pass without it. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #16003 and [Bug 1351356](https://bugzilla.mozilla.org/show_bug.cgi?id=1351356) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16231) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Gecko supports a different syntax for
matrixandmatrix3dfunction in-moz-transformproperty. Specifically, when the property is prefixed, it accepts<length>in addition to<number>for transition parts of the matrix functions.That says, this kind of syntax are valid for
-moz-transform:while in
transform, only<number>s are allowed.